From f2e34f162af326aace8ca6d9d0ca26e1159b3706 Mon Sep 17 00:00:00 2001
From: "Juan J. Martinez" <jjm@usebox.net>
Date: Mon, 25 Jan 2021 15:57:10 +0000
Subject: Reviewed makefiles

---
 game/data/Makefile   |  4 ++--
 game/src/Makefile    | 30 +++++++++++++++---------------
 src/ap/Makefile      | 10 +++++-----
 src/mplayer/Makefile | 10 +++++-----
 src/spman/Makefile   | 12 ++++++------
 src/ubox/Makefile    | 10 +++++-----
 tools/Makefile       |  2 +-
 7 files changed, 39 insertions(+), 39 deletions(-)

diff --git a/game/data/Makefile b/game/data/Makefile
index 22d26c2..70f7f6d 100644
--- a/game/data/Makefile
+++ b/game/data/Makefile
@@ -1,5 +1,5 @@
-OUTPUT=../generated
-GENERATED=$(OUTPUT)/tiles.h $(OUTPUT)/player.h $(OUTPUT)/enemy.h $(OUTPUT)/map.h
+OUTPUT := ../generated
+GENERATED := $(OUTPUT)/tiles.h $(OUTPUT)/player.h $(OUTPUT)/enemy.h $(OUTPUT)/map.h
 
 all: $(GENERATED)
 
diff --git a/game/src/Makefile b/game/src/Makefile
index f05d1fa..6ac7a0a 100644
--- a/game/src/Makefile
+++ b/game/src/Makefile
@@ -1,22 +1,22 @@
-TARGET = game
+TARGET := game
 
-CODE = 0x4000
+CODE := 0x4000
 # leaves 222 bytes for AKM player buffer
-DATA = 0xc0de
+DATA := 0xc0de
 
 # HEX, will fill with 0
-ROM_MAX = 8000
-
-OUTPUT = ../build
-OBJS = $(patsubst %.c,$(OUTPUT)/%.rel,$(wildcard *.c)) $(OUTPUT)/akm.rel
-UBOX_LIBS = $(wildcard ../../lib/*.lib)
-LIBS = -lubox -lspman -lmplayer -lap
-
-CC = sdcc
-AS = sdasz80
-AR = sdcclib
-CFLAGS = -mz80 --Werror -I../../include -I../generated --fsigned-char --std-sdcc99 --opt-code-speed
-LDFLAGS = -L../../lib -L. --no-std-crt0 --fomit-frame-pointer
+ROM_MAX := 8000
+
+OUTPUT := ../build
+OBJS := $(patsubst %.c,$(OUTPUT)/%.rel,$(wildcard *.c)) $(OUTPUT)/akm.rel
+UBOX_LIBS := $(wildcard ../../lib/*.lib)
+LIBS := -lubox -lspman -lmplayer -lap
+
+CC := sdcc
+AS := sdasz80
+AR := sdcclib
+CFLAGS := -mz80 --Werror -I../../include -I../generated --fsigned-char --std-sdcc99 --opt-code-speed
+LDFLAGS := -L../../lib -L. --no-std-crt0 --fomit-frame-pointer
 
 all: $(OUTPUT)/$(TARGET).rom
 	@../../tools/chksize 8000 4000 $(OUTPUT)/$(TARGET).map
diff --git a/src/ap/Makefile b/src/ap/Makefile
index 3559f71..1065466 100644
--- a/src/ap/Makefile
+++ b/src/ap/Makefile
@@ -1,11 +1,11 @@
-LIB = ../../lib/ap.lib
+LIB := ../../lib/ap.lib
 all: $(LIB)
 
-AS = sdasz80
-AR = sdar
+AS := sdasz80
+AR := sdar
 
-SOURCES = ap.z80
-OBJS = $(patsubst %.z80,%.rel,$(SOURCES))
+SOURCES := ap.z80
+OBJS := $(patsubst %.z80,%.rel,$(SOURCES))
 
 $(LIB): $(OBJS)
 	$(AR) -rcD $(LIB) $(OBJS)
diff --git a/src/mplayer/Makefile b/src/mplayer/Makefile
index 81e099b..cf642f8 100644
--- a/src/mplayer/Makefile
+++ b/src/mplayer/Makefile
@@ -1,11 +1,11 @@
-LIB=../../lib/mplayer.lib
+LIB := ../../lib/mplayer.lib
 all: $(LIB)
 
-AS=sdasz80
-AR=sdar
+AS := sdasz80
+AR := sdar
 
-SOURCES=$(wildcard *.z80)
-OBJS=$(patsubst %.z80,%.rel,$(SOURCES))
+SOURCES := $(wildcard *.z80)
+OBJS := $(patsubst %.z80,%.rel,$(SOURCES))
 
 $(LIB): $(OBJS)
 	$(AR) -rcD $(LIB) $(OBJS)
diff --git a/src/spman/Makefile b/src/spman/Makefile
index b2bc5df..49b7de9 100644
--- a/src/spman/Makefile
+++ b/src/spman/Makefile
@@ -1,12 +1,12 @@
-LIB=../../lib/spman.lib
+LIB := ../../lib/spman.lib
 all: $(LIB)
 
-CC=sdcc
-AR=sdar
-CFLAGS=-mz80 --Werror -I../../include --fsigned-char --std-sdcc99 --opt-code-speed
+CC := sdcc
+AR := sdar
+CFLAGS := -mz80 --Werror -I../../include --fsigned-char --std-sdcc99 --opt-code-speed
 
-SOURCES=$(wildcard *.c)
-OBJS=$(patsubst %.c,%.rel,$(SOURCES))
+SOURCES := $(wildcard *.c)
+OBJS := $(patsubst %.c,%.rel,$(SOURCES))
 
 $(LIB): $(OBJS)
 	$(AR) -rcD $(LIB) $(OBJS)
diff --git a/src/ubox/Makefile b/src/ubox/Makefile
index a597090..1d8e27e 100644
--- a/src/ubox/Makefile
+++ b/src/ubox/Makefile
@@ -1,11 +1,11 @@
-LIB=../../lib/ubox.lib
+LIB := ../../lib/ubox.lib
 all: $(LIB)
 
-AS=sdasz80
-AR=sdar
+AS := sdasz80
+AR := sdar
 
-SOURCES=$(wildcard ubox_*.z80)
-OBJS=$(patsubst %.z80,%.rel,$(SOURCES))
+SOURCES := $(wildcard ubox_*.z80)
+OBJS := $(patsubst %.z80,%.rel,$(SOURCES))
 
 $(LIB): $(OBJS)
 	$(AR) -rcD $(LIB) $(OBJS)
diff --git a/tools/Makefile b/tools/Makefile
index 58b23f1..328b5a1 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -1,4 +1,4 @@
-BIN=../bin/hex2bin ../bin/rasm ../bin/apultra
+BIN := ../bin/hex2bin ../bin/rasm ../bin/apultra
 
 all: $(BIN)
 
-- 
cgit v1.2.3